Skip to content

removing unecessary boolean parsing in check.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsoch merged 1 commit into from
Apr 5, 2020
Merged

removing unecessary boolean parsing in check.py #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions urlchecker/client/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,6 @@
logger = logging.getLogger('urlchecker')


def str2bool(str_bool):
"""
Convert str input to boolean

Args:
- str_bool (str) : boolean variable as an str.

Returns
bool
"""
if isinstance(str_bool, bool):
return str_bool
if str_bool.lower() in ('true', 't', 'y', '1'):
return True
elif str_bool.lower() in ('no', 'false', 'f', 'n', '0'):
return False
else:
raise ArgumentTypeError('Boolean value expected.')


def main(args, extra):
"""
main entrypoint for running a check. We expect an args object with
Expand Down Expand Up @@ -73,23 +53,18 @@ def main(args, extra):
white_listed_patterns = remove_empty(args.white_listed_patterns.split(","))
white_listed_files = remove_empty(args.white_listed_files.split(","))

# parse booleans
cleanup = str2bool(args.cleanup)
print_all = not str2bool(args.no_print)
force_pass = str2bool(args.force_pass)

# Alert user about settings
print(" original path: %s" % args.path)
print(" final path: %s" % path)
print(" subfolder: %s" % args.subfolder)
print(" branch: %s" % args.branch)
print(" cleanup: %s" % cleanup)
print(" cleanup: %s" % args.cleanup)
print(" file types: %s" % file_types)
print(" print all: %s" % print_all)
print(" print all: %s" % (not args.no_print))
print(" url whitetlist: %s" % white_listed_urls)
print(" url patterns: %s" % white_listed_patterns)
print(" file patterns: %s" % white_listed_files)
print(" force pass: %s" % force_pass)
print(" force pass: %s" % args.force_pass)
print(" retry count: %s" % args.retry_count)
print(" save: %s" % args.save)
print(" timeout: %s" % args.timeout)
Expand All @@ -100,7 +75,7 @@ def main(args, extra):
white_listed_files=white_listed_files,
white_listed_urls=white_listed_urls,
white_listed_patterns=white_listed_patterns,
print_all=print_all,
print_all=not args.no_print,
retry_count=args.retry_count,
timeout=args.timeout)

Expand Down