fix(model): let loadLocationStables honour forceMinimum - #409
Closed
Ryanmello07 wants to merge 1 commit into
Closed
Conversation
The read side hardcoded forceMinimum=false, so a location where every provider fails the minimums gate was invisible even to callers that explicitly bypass minimums. Providers there could never be probed and so could never graduate probation. The writer already populates both key families; this only chooses between them. User-facing listing still passes false. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QtgqtCmKJRXdsQ5ktiqwkg
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadLocationStableshardcodedforceMinimum=falseon the read side, so a location whose every provider fails the minimums gate is invisible even to callers that explicitly bypass minimums. Location enumeration happens before provider selection, soforce_minimumonfind-providers2cannot recover a location the listing never emitted — those providers can never be reached and never improve their standing.The writer (
UpdateClientScores->exportClientScores, which loopsfor _, forceMinimum := range []bool{false, true}) already populates both key families, so this only chooses between them. No new data, no new keys.Both existing callers —
GetProviderLocationsandFindProviderLocations— passfalseexplicitly, so user-facing location listing is byte-for-byte unchanged.New test
TestLoadLocationStablesHonoursForceMinimum: one connected+valid Public provider with no latency or speed samples (deterministically below the minimums); its country is absent underfalseand present undertrue.🤖 Generated with Claude Code
https://claude.ai/code/session_01QtgqtCmKJRXdsQ5ktiqwkg