Add writeFragment dependencies test#578
Closed
kitten wants to merge 3 commits into
Closed
Conversation
💥 No ChangesetLatest commit: 9c3cc88 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
kitten
force-pushed
the
chore/add-writefragment-test
branch
from
25617eb to
ab41749
Compare
kitten
force-pushed
the
chore/add-writefragment-test
branch
from
ab41749 to
9e82b7c
Compare
kitten
force-pushed
the
chore/add-writefragment-test
branch
from
9e82b7c to
40caaed
Compare
The commutative squashing would previously only start when the lowest commutative layer (the first one) was written. This ignored the case however of when this layer has already been written. When this was the case the stopping condition was unreachable and commutative layers were never squashed. The change is to continuously squash the commutative layers with the least priorities as they're written. This change also gets rid of the temporary `squash` queue, which ends up making it a rather nice implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #574