feat(web): inline label popover replaces window.prompt in Gallery#628
Merged
Conversation
The Add-label affordance on gallery cards now opens an anchored popover (useDialog — the same primitive as the other anchored menus) with an auto-focused input, Enter-to-add, Escape-to-dismiss, focus restore to the chip, and a datalist of the labels already present in the listing. Event containment keeps clicks/keys inside the popover from reaching the keyboard-activatable card behind it, and escapeLayers integration means Escape never leaks to the lightbox or route. Follow-up polish to #626. Validation: web typecheck + 860 unit tests + build:ci; e2e 120/120; browser-QA'd against a seeded demo workspace (open/focus, submit chip, Escape no-add, no lightbox leak, datalist suggestion) — zero page errors.
gbasin
enabled auto-merge
July 21, 2026 13:41
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish to #626: the Add-label affordance on gallery cards opens an inline anchored popover instead of
window.prompt.useDialog(same primitive as ChannelMembersMenu/MessageActionMenu): input auto-focus on open, focus restore to the chip on close,escapeLayersintegration so Escape closes only the popoverdatalistof the distinct labels already in the listing (minus ones on that file)aria-haspopup="dialog"/aria-expandedand stays visible while openValidation: web typecheck, 860 unit tests (popover open/submit/Escape cases),
build:ci, full local e2e 120/120 exit 0, and hands-on browser QA (9/9 checks: open/focus, chip added, Escape no-add, no lightbox leak, datalist suggestion, zero page errors).