Skip to content

Discover the agent address from BLACKSMITH_AGENT_ADDR - #12

Merged
piob-io merged 3 commits into
mainfrom
agent-addr-discovery
Jul 30, 2026
Merged

Discover the agent address from BLACKSMITH_AGENT_ADDR#12
piob-io merged 3 commits into
mainfrom
agent-addr-discovery

Conversation

@piob-io

@piob-io piob-io commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Uses the BLACKSMITH_AGENT_ADDR env var the agent advertises (FastActions/fa#4816) as the host part of the metadata service address; the action contains no hardcoded agent IPs. When BLACKSMITH_AGENT_ADDR is unset or metadata_port is absent from the kernel cmdline, the action warns, sets available=false, and every downstream step no-ops, so the job continues without a testbox session.

Requires the agent change (FastActions/fa#4816) to be rolled out fleet-wide before this is released.


View with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is enabled. (Staging)


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@piob-io
piob-io force-pushed the agent-addr-discovery branch from d01af38 to ca9f70e Compare July 29, 2026 16:36
@piob-io piob-io changed the title Prefer BLACKSMITH_AGENT_ADDR for the metadata service address Discover the agent address from BLACKSMITH_AGENT_ADDR Jul 29, 2026
@piob-io
piob-io marked this pull request as ready for review July 29, 2026 20:36
@piob-io
piob-io requested a review from taha-au July 29, 2026 21:40
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
@piob-io
piob-io force-pushed the agent-addr-discovery branch from ca9f70e to bf58aec Compare July 29, 2026 21:49
Comment thread action.yml Outdated
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c78e26. Configure here.

Comment thread action.yml
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
@piob-io
piob-io merged commit ad4fbed into main Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants