chore(lint): warn on panic!() usage#145
Closed
sachiniyer wants to merge 1 commit intolint/warn-expect-usedfrom
Closed
chore(lint): warn on panic!() usage#145sachiniyer wants to merge 1 commit intolint/warn-expect-usedfrom
sachiniyer wants to merge 1 commit intolint/warn-expect-usedfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 6, 2026
This was referenced Mar 6, 2026
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
No panic!() calls should exist in the CLI — use proper error handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sachiniyer
force-pushed
the
lint/warn-panic
branch
from
940009c to
facea71
Compare
sachiniyer
force-pushed
the
lint/warn-expect-used
branch
from
2c08342 to
b8a775a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches explicit panic!() calls in non-test code.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com