Skip to content

chore(lint): warn on expect() usage#144

Merged
sachiniyer merged 1 commit intomainfrom
lint/warn-expect-used
Mar 7, 2026
Merged

chore(lint): warn on expect() usage#144
sachiniyer merged 1 commit intomainfrom
lint/warn-expect-used

Conversation

@sachiniyer
Copy link
Copy Markdown
Contributor

@sachiniyer sachiniyer commented Mar 6, 2026

Encourages full Result/Option handling instead of .expect() calls.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Open with Devin

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Upgrades unwrap_used to deny (hard error) — bare .unwrap() should never
be used in the CLI. Also adds expect_used as a warning.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sachiniyer sachiniyer force-pushed the lint/warn-expect-used branch from 2c08342 to b8a775a Compare March 7, 2026 00:17
@sachiniyer sachiniyer merged commit 04c59f8 into main Mar 7, 2026
12 checks passed
@sachiniyer sachiniyer deleted the lint/warn-expect-used branch March 7, 2026 00:40
sachiniyer added a commit that referenced this pull request Mar 12, 2026
## Summary
- Bumps version from 0.1.10 to 0.1.11
- The release workflow will auto-tag and build artifacts when merged to
main

### Changes since v0.1.10

**Features:**
- Add shell tab completion via clap_complete (#182)
- Add --scan-id flag to bugs list command (#184)
- Add scans list command (#163)
- Add scans to the skill.md for the detail CLI (#185)
- Auto-detect repository in detail-bugs skill (#160)

**Fixes:**
- Show user-friendly error messages instead of debug output (#129)
- Continue list numbering across pages instead of resetting (#130)
- Add file locking to prevent concurrent config overwrites (#131)

**Chores & Refactoring:**
- Replace Makefile with cargo xtask (#159)
- Upgrade all dependencies to latest versions (#158)
- Enable comprehensive clippy lints (pedantic, nursery, restriction)
(#134, #135, #144, #152, #153, #154, #155)
- Add GitHub Pages workflow for API docs (#178)
- Add Scalar API reference page (#177)
- Add integration tests against live API (#181)
- Remove alpha warning from README (#156)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant