fix: address all four open CLI issues (#323, #326, #328, #329)

[devin-ai-integration]

Summary

All four open issues in this repo were small, well-localized correctness bugs, each fixed with a unit test:

• [Detail Bug] CLI: bugs show displays dangling em-dash when Fix PR URL is empty #323 format_fix_pr unconditionally appended — {url}, so an empty FixPr.url rendered #42 (merged) — . Now branches on url.is_empty(), matching format_linked_issue/Bug::to_card.
• [Detail Bug] CLI: Inferring GitHub repo from jj remote list includes '(push: ...)' annotation, producing malformed repo IDs #326 parse_jj_remote_list returned everything after origin , including jj's (push: <url>) annotation, which flowed through as a garbage repo id (owner/repo.git (push: https:) that passed validation. Now splits on " (push:" and keeps the fetch URL.
• [Detail Bug] CLI: Filtered scans/bugs list can show impossible pagination (page > total pages) #328 The client-side-filtered bugs list / scans list paths paginated with the raw requested page, producing Page: 5 of 1. New output::clamp_page(page, total, limit) -> page.clamp(1, total_pages(total, limit)) is applied before paginate_items/output_list on both filtered paths, so the page number and the items shown stay consistent.
• [Detail Bug] VCS: Repo auto-inference fails for HTTPS remotes when password/token contains '@' #329 strip_http_credentials used split_once('@'); the credentials/host separator is the last @, so https://user:p@ss@github.com/owner/repo.git yielded host ss@github.com and inference returned None. Switched to rsplit_once('@'), matching strip_ssh_port in the same file.

Note: the local toolchain had to be updated to current stable (chacha20 0.10.1 requires edition 2024) to build; cargo fmt --check, cargo clippy -- -D warnings, cargo test, and cargo xtask check all pass. cargo clippy --all-targets on current stable flags two preexisting lints untouched by this PR (src/commands/completions.rs:59 redundant closure, trailing commas in tests/integration.rs); CI only runs cargo clippy without --all-targets, so they don't gate this PR.

Closes #323, closes #326, closes #328, closes #329.

Link to Devin session: https://app.devin.ai/sessions/fb903d8badf449c69bcb0e3b20a52a30
Requested by: @sachiniyer

---

---

Summary by cubic

Fixes four CLI correctness bugs in PR formatting, remote URL parsing, pagination, and HTTPS credential handling to improve output accuracy and repo inference. Adds unit tests for each fix.

• Bug Fixes
  • Omit the em dash and URL when FixPr.url is empty in format_fix_pr ([Detail Bug] CLI: bugs show displays dangling em-dash when Fix PR URL is empty #323).
  • Strip jj’s (push: <url>) annotation in parse_jj_remote_list to keep the fetch URL ([Detail Bug] CLI: Inferring GitHub repo from jj remote list includes '(push: ...)' annotation, producing malformed repo IDs #326).
  • Clamp page numbers after client-side filtering in bugs list and scans list to keep pages and items consistent ([Detail Bug] CLI: Filtered scans/bugs list can show impossible pagination (page > total pages) #328).
  • Split HTTPS credentials on the last @ so passwords with @ parse correctly ([Detail Bug] VCS: Repo auto-inference fails for HTTPS remotes when password/token contains '@' #329).

^{Written for commit 936f2b0. Summary will update on new commits.}

[devin-ai-integration]

Original prompt from Sachin

Can you fix all the open issues in the cli repo. Decide if they are worth fixing and then delegate to another agent to fix if you need to

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state pending): this PR has not been approved.

Pending Status Checks

• ✅ 7 tests passing!

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

[devin-ai-integration]

Runtime verification (all four fixes)

Built this branch and a main baseline binary and ran them side-by-side against a local mock Detail API (no production token available in this environment) plus scratch git/jj repos.

1+2. clamp_page: out-of-range page clamps to the last real page

detail bugs list usedetail/cli --status pending,resolved --since 30d --limit 2 --page 5 (5 matches ÷ 2 = 3 pages). Old: Page: 5 of 3 with zero rows. New: Page: 3 of 3 showing the actual last-page item bug_05.

Same in JSON — old page=5, total_pages=3, items=[] vs new page=3, total_pages=3, items=[bug_05]:

Scans path --status failed --limit 2 --page 9 (3 failed → 2 pages): old Page: 9 of 2 empty, new Page: 2 of 2 showing wr_05. Regression: --page 1 still Page: 1 of 2 with wr_01+wr_03.

3. format_fix_pr: no dangling em-dash when fixPr.url is empty

detail bugs show <id> | grep 'Fix PR' | cat -A — old ends #42 (merged) M-bM-^@M-^T $, new ends #42 (merged)$. A bug with a real URL still renders #43 (merged) — https://github.com/usedetail/cli/pull/43.

4. Repo inference: @ in HTTPS credentials, and jj (push: …) annotation

Scratch repo with origin = https://user:p@ss@github.com/usedetail/cli.git, no repo argument passed. Old: Error: Could not infer repository from git or jj remotes. New: resolves usedetail/cli.

jj workspace (no .git, so the jj fallback is the only path) where jj git remote list prints origin https://github.com/usedetail/cli.git (push: https://other.example.com/mirror/cli.git). Old: Repository 'usedetail/cli.git (push: https:' not found. New: resolves usedetail/cli.

Gates

cargo build, cargo test, cargo clippy -- -D warnings, cargo fmt --check, cargo xtask check — all pass.

Caveats: no Detail API token in the test environment, so a local mock API was used instead of production; cargo clippy --all-targets -- -D warnings fails, but identically on main (pre-existing lints in tests/integration.rs and src/commands/completions.rs).