[pull] master from ceph:master#283
Merged
pull[bot] merged 15 commits intousefulalgorithm:masterfrom Oct 4, 2019
Merged
Conversation
will add rados_{set,unset}_pool_full_try() in a follow-up change, which
reflect the change of b4ca5ae
Signed-off-by: Kefu Chai <kchai@redhat.com>
and s/osdmap_full_try/pool_full_try/ Signed-off-by: Kefu Chai <kchai@redhat.com>
b4ca5ae has dropped them since v13.0.1, so we don't need to do this in v15 anymore even if user upgrades an existing cluster from v13. Signed-off-by: Kefu Chai <kchai@redhat.com>
this flag is not honored by client or cluster anymore Signed-off-by: Kefu Chai <kchai@redhat.com>
per-pool full flag has taken the place of it since b4ca5ae Signed-off-by: Kefu Chai <kchai@redhat.com>
these flags has been deprecated since b4ca5ae Signed-off-by: Kefu Chai <kchai@redhat.com>
they will deprecate rados_unset_osdmap_full_try() Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
and deprecate IoCtx::{set,unset}_osdmap_full_try()
the latter are deprecated and are aliases of the former.
Signed-off-by: Kefu Chai <kchai@redhat.com>
as set_osdmap_full_try() is deprecated now Signed-off-by: Kefu Chai <kchai@redhat.com>
instead of using `std::pair<>` for presenting it. there are three advantages: 1. better names for readability: `type` and `name` are better names than `first` and `second` 2. so we can specliaze its behavior by its type: define `operator<<` once, and use it everywhere. no need to worry about ADL to pickup the generic operator of `operator<< (..., pair<>)` anymore. so we can safely use `<< key`, and no need to use `<< key.first << '.' << key.second`. kill the printed form of `osd,1` once and for all, all of them are now "osd.1". 3. consolidate the print/parse in a single place Fixes: https://tracker.ceph.com/issues/42079 Signed-off-by: Kefu Chai <kchai@redhat.com>
`ceph {set,unset} full` does not take effect since mimic, and monitor
does not support this command since Octopus. so let's document this
change.
Signed-off-by: Kefu Chai <kchai@redhat.com>
mgr: use a struct for DaemonKey Reviewed-by: Neha Ojha <nojha@redhat.com> Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: Kefu Chai <kchai@redhat.com>
librados,osd,mon: remove traces of CEPH_OSDMAP_FULL Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )