Add Java version file to workflows#572
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes the Java version used in GitHub Actions by introducing a repository-level .java-version file and updating workflows to read the JDK version from that file instead of hard-coding it in each workflow.
Changes:
- Add a root
.java-versionfile set to Java25. - Update the publish workflow to use
java-version-file: .java-version. - Update the dependency diff workflow to use
java-version-file: .java-version(which also changes its effective Java version from 23 to 25).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.java-version |
Adds a single source of truth for the Java version (25). |
.github/workflows/publish.yaml |
Switches setup-java to read the Java version from .java-version. |
.github/workflows/dependencies.yml |
Switches setup-java to read the Java version from .java-version (implicitly changing the job’s JDK from 23 to 25). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
+28
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: 23 | ||
| java-version-file: .java-version |
Jar size:Jar size change: +0.0B (3.4MiB -> 3.4MiB) Diffuse output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.