Merged
Conversation
shreddedbacon
force-pushed
the
fix-build-cleanup-on-creation
branch
from
0df5f55 to
4431d63
Compare
bomoko
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Spotted in the wild, if a namespace is stuck terminating and a build comes through for that namespace again, the remote-controller crashes with a panic nil pointer error until the namespace is cleaned up. This prevents new builds from processing as the controller continues to crash and the build is never removed from the messagequeue.
This fixes the points that caused the nil pointer issue, and also fixes the missing
UIDin the build so that the logs for these builds appear in the API correctly.