Skip to content

fix: cleanup role when the pod completes or fails#329

Merged
rocketeerbkw merged 1 commit intomainfrom
activestandby-role-cleanup
Oct 22, 2025
Merged

fix: cleanup role when the pod completes or fails#329
rocketeerbkw merged 1 commit intomainfrom
activestandby-role-cleanup

Conversation

@shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

The active/standby task role that gets created to perform the actions wasn't always cleaned up at completion of the pod.

This fixes the issue by moving the role cleanup to the pod reconcile process to ensure the role is properly removed at completion of the task.

@shreddedbacon shreddedbacon marked this pull request as ready for review October 19, 2025 20:46
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@rocketeerbkw rocketeerbkw merged commit ac95abc into main Oct 22, 2025
13 checks passed
@rocketeerbkw rocketeerbkw deleted the activestandby-role-cleanup branch October 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants