tags parser make a mistake in url with `#`

[MoCongxin]

Describe the bug

e.g.:
chrome://net-internals/#hsts

#hsts will parse as a tag

Steps to reproduce

create a note, and typing chrome://net-internals/#hsts

Screenshots or additional context

[Zeng1998]

Which version? I cannot reproduce on the demo site.

[Yinr]

Which version? I cannot reproduce on the demo site.

I tested in demo site, and the wrong tag is found in tag suggestions.

Since go is not support before text matching((?=re)), tagRegexp may be like (^|\s)#([^\s#/][^\s#]*) and then get the second catch group?

[MoCongxin]

@Zeng1998 I use v0.10.3 now, but this problem may be appear in older version too.

[Zeng1998]

So can you reproduce on the demo site? I am sure there is no such issue on my Memos instance and the demo.

[Yinr]

Yes, in demo site, but the wrong tag only shows in Create Tag -> Tag suggestions.

[MoCongxin]

@Zeng1998 sure, the same thing in demo site.

[Issues-translate-bot]

Issue is not in English. It has been translated automatically.

---

@Zeng1998 sure, the same thing in demo site.

[Zeng1998]

Are you sure that you (or other users) didn't add this tag (abcd) manually?

[Zeng1998]

As for the tag suggestion, I prefer to regard it as a feature, not a bug.

[MoCongxin]

@Zeng1998 I record a video for you, and I think @Yinr was explained clearly.

Which version? I cannot reproduce on the demo site.

I tested in demo site, and the wrong tag is found in tag suggestions.

Since go is not support before text matching((?=re)), tagRegexp may be like (^|\s)#([^\s#/][^\s#]*) and then get the second catch group?

Yes, in demo site, but the wrong tag only shows in Create Tag -> Tag suggestions.

BTW, I dont think it is a good idea to consider this as a feature, because every time you save a url with # will create an unexpect tag.

[Zeng1998]

As shown by this video, there is no bug here. It is as expected for now.