ci: pin ruff to 0.15.22 to unbreak main#480
Merged
Merged
Conversation
ruff 0.16.0 (released 2026-07-23) enabled a large new default rule surface (UP045/UP006/UP035, I001, BLE001, S110, RUF*, SIM*, ...) that flags ~460 pre-existing findings across the repo. Because both the python-lint job and the python-sdk-test job install ruff unpinned, main and every open PR went red the moment 0.16.0 shipped, ~4 minutes before the next main run. No .py changed between the last green run (0.15.22) and the first red one, so pinning to 0.15.22 restores green. Verified locally: 'ruff check .' and the SDK 'ruff check src/ tests/' both pass clean under 0.15.22. This is a stopgap to unblock merges; the 0.16.0 findings can be addressed (or selectively ignored) in a follow-up, then the pin bumped.
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the Python linter ruff in CI to prevent newly released upstream versions from breaking required checks across the repo, restoring reliability for merges while a follow-up can address newly surfaced lint findings.
Changes:
- Pin
ruffto0.15.22in thepython-lintGitHub Actions job. - Pin
ruffto0.15.22in thepython-sdk-testGitHub Actions job, matching thepython-lintpin and documenting the rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codex reviewNo issues found. |
ashvathsureshkumar
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainand every open PR are currently red on the required checkspython-lintandpython-sdk-test(all Python versions).Root cause is a floating linter, not any code change:
pip install ruffin thepython-lintjob and again in thepython-sdk-test"Lint with ruff" step).2026-07-23T19:10:46Z. The nextmainrun (378d72b/c3e6ddb) executed at19:14Z— ~4 minutes later — and picked it up.UP045(120),I001(84),UP006(79),BLE001(71),UP035(31), plusS110,RUF*,SIM*,DTZ005, etc.The last green
mainruns (01:00Z the same day) used ruff 0.15.22. No.pychanged between those and the first red run (only.yml/ lockfiles), so this is purely the ruff version.Fix
Pin both installs to
ruff==0.15.22(the last green version), with a comment explaining why.Verification (local, on current
main)ruff==0.15.22 check . --extend-exclude '**/*.ipynb'-> All checks passed!ruff==0.15.22 check src/ tests/insdks/python/sdk-> All checks passed!Note
This is a deliberate stopgap to unblock merges immediately. The 460 findings under 0.16.0 are real lint signal; a follow-up can address (or selectively
ignore) them and then bump the pin. Filing/So they don't get lost, happy to open that follow-up.