⚡ perf: replace pedcols unordered_map with fast struct array access - #239
Merged
AmeerDotEXE merged 1 commit intoAug 1, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the PedCols render path by removing a per-render std::unordered_map lookup and instead storing per-ped “original material color” restore data directly in the existing PedData extended-data object, avoiding map growth and improving cache locality.
Changes:
- Added
PedData::m_OriginalColorsto hold original material color state per ped. - Updated the material-editing render hook to append restore entries to
PedDatainstead of a global map. - Updated the post-render hook to restore colors from
PedDataand clear the vector each frame.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/features/pedcols.h | Adds per-ped storage for original material colors in PedData. |
| src/features/pedcols.cpp | Switches render-time save/restore from a global unordered_map to per-ped extended-data vector storage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Moves the temporary render color storage from a global std::unordered_map keyed by CPed pointers to the struct-managed PedData. This completely avoids O(N) heap allocations resulting from hash bucket insertions and improves lookup speed to O(1) via the fast data extender pool. Previous map implementation also resulted in an implicit memory leak as map entries were `.clear()`ed rather than `.erase()`d.
AmeerDotEXE
approved these changes
Aug 1, 2026
AmeerDotEXE
left a comment
AmeerDotEXE
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just need to change the type but i'll do that
no action needed
AmeerDotEXE
force-pushed
the
perf-pedcols-map-optimization-7564270330963687533
branch
from
August 1, 2026 21:12
6796b84 to
6da219a
Compare
CanerKaraca23
deleted the
perf-pedcols-map-optimization-7564270330963687533
branch
August 1, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What:
Replaced the
std::unordered_map<CPed*, std::vector<std::pair<void*, int>>> storeinsrc/features/pedcols.cppwith a memberstd::vector<std::pair<void*, int>> m_OriginalColorsinside the existingPedDataextended data class.🎯 Why:
The previous implementation performed hash map lookups (
store[pPed]) for every atomic render during the rendering loop. This causes notable CPU overhead due to hash calculation and cache miss penalties. Furthermore, whilestore[pPed].clear()was called after rendering, it only cleared the nested vector and did not erase the map key, leading to a gradual memory leak as new peds spawned over time.📊 Measured Improvement:
A standalone benchmark simulating 10,000 iterations over 100 peds demonstrated the following improvements: