Fix DefaultPermissions.php SQL Error#983
Merged
Silic0nS0ldier merged 1 commit intouserfrosting:hotfixfrom May 26, 2019
Merged
Conversation
Member
|
@noellekimiko can you confirm this fix your issue described in #981 ? |
lcharette
approved these changes
May 25, 2019
Codecov Report
@@ Coverage Diff @@
## hotfix #983 +/- ##
============================================
- Coverage 61.26% 61.05% -0.21%
- Complexity 2136 2212 +76
============================================
Files 159 159
Lines 7241 7478 +237
============================================
+ Hits 4436 4566 +130
- Misses 2805 2912 +107
Continue to review full report at Codecov.
|
Member
|
Don't forget to update the Changelog when merging a PR :) |
Contributor
Author
|
Should I be doing that when I open PR or just on your end when you merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed sql error when running
php bakery seed DefaultPermissionsas noted in issue #981