fix core: use peer address for websocket client connections - #1276
Closed
seriouscoder43 wants to merge 2 commits into
Closed
fix core: use peer address for websocket client connections#1276seriouscoder43 wants to merge 2 commits into
seriouscoder43 wants to merge 2 commits into
Conversation
apolukhin
requested changes
Jun 30, 2026
Member
|
LGTM |
Member
|
LGTM |
Member
|
LGTM |
|
Many thanks for the PR! @apolukhin is now importing your pull request into our internal upstream repository. |
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
robot-piglet
pushed a commit
that referenced
this pull request
Aug 11, 2026
MakeWebsocketConnection() incorrectly uses Getsockname() to save the remote peer. Then connection's RemoteAddr() becomes always wrong --- Pull Request resolved: #1276 Co-authored-by: Antony Polukhin <antoshkka@gmail.com> commit_hash:58f1216f00993df5fa32023535fca906e7db37bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeWebsocketConnection() incorrectly uses Getsockname() to save the remote peer. Then connection's RemoteAddr() becomes always wrong