Conversation
|
@magicspon is attempting to deploy a commit to the kmkoushik's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis pull request adds a new GET endpoint specification to the OpenAPI documentation for Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile OverviewGreptile SummaryThis PR adds an OpenAPI The change fits into the existing docs repo pattern where API endpoints are described directly in Confidence Score: 4/5
|
| { | ||
| "schema": { "type": "string", "default": "1", "example": "1" }, | ||
| "required": false, |
There was a problem hiding this comment.
Wrong type for page
page is documented as a string ({"type":"string","default":"1"}), but it represents a page number. This will generate incorrect client types and allows non-numeric values. It should be an integer (optionally with minimum: 1) and defaults/examples should be numeric.
| { | |
| "schema": { "type": "string", "default": "1", "example": "1" }, | |
| "required": false, | |
| "schema": { "type": "integer", "minimum": 1, "default": 1, "example": 1 }, |
| "status": { "type": "string" }, | ||
| "scheduledAt": { "type": "string", "nullable": true, "format": "date-time" }, | ||
| "total": { "type": "integer" }, |
There was a problem hiding this comment.
Enum missing for status
In the 200 response schema, each campaign’s status is currently just {"type":"string"}. Since you already define the allowed values in the status query param, leaving the response unconstrained will produce weaker/incorrect generated types and inconsistent docs. Consider adding the same enum to the response field.
| "status": { "type": "string" }, | |
| "scheduledAt": { "type": "string", "nullable": true, "format": "date-time" }, | |
| "total": { "type": "integer" }, | |
| "status": { "type": "string", "enum": ["DRAFT","SCHEDULED","IN_PROGRESS","PAUSED","COMPLETED","CANCELLED"] }, |
Adds the missing API reference documentation for get /v1/campaigns
Summary by cubic
Adds the missing API reference for GET /v1/campaigns with pagination, filtering, and response schema. Addresses the Linear issue about missing get-campaigns docs.
Written for commit 1d1216a. Summary will update on new commits.
Summary by CodeRabbit
Release Notes