expand firebase storage rules coverage - #1002
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR expands the Firebase skill to cover Firebase Storage Security Rules separately from GCS IAM and ACLs, while exposing skill descriptions in agent prompts.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (5): Last reviewed commit: "Parse skill frontmatter with YAML" | Re-trigger Greptile |
Collaborator
Author
Contributor
Contributor
Contributor
0xallam
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloud Storage sits behind two front doors with different authorization engines, and the Firebase skill only documented one of them:
storage.googleapis.com/<bucket>/<object>,/storage/v1/b/<bucket>firebasestorage.googleapis.com/v0/b/<bucket>/oThe string
firebasestorage.googleapis.comappeared nowhere in the repo, so an agent that probed the GCS door, got403on everything, and saw noallUsersbucket grant would conclude the bucket was locked down — while rules likeallow read, write: if request.time < timestamp.date(2027, 5, 4)(the console test-mode default) grant unauthenticated read and write to every object through the other door. The skill now documents both doors, the unauth/anonymous/low-privilege list+read+write probe matrix, the dangerous rule patterns (time gate,{allPaths=**},request.auth != nullas sole gate, claim-presence checks), Storage rules' OR-across-matches semantics, bucket discovery, and object-ACL persistence after a rules fix.It also fixes a whitebox failure mode: absent rules IaC was being read as nothing to review. Missing
storage/firestoreblocks infirebase.json, or a referenced rules file absent from the tree, means the live rules are unmanaged and default to test-mode open — that is itself a finding and must force live probing.Second, the coordinator couldn't see any of this when picking skills.
get_available_skills()returned names only, sotechnologies/firebase_firestorewas all the root agent had to go on and Storage coverage was invisible at selection time. The skill is renamedtechnologies/firebaseand descriptions are now exposed and rendered:Supporting cleanup in
strix/skills/__init__.py: frontmatter is parsed once by a shared_parse_skill_content() -> (metadata, body)used by both discovery andload_skills()(replacing the body-only_FRONTMATTER_PATTERN.sub), viayaml.safe_loadso block scalars and comments in adescriptioncan't leak a malformed value into every system prompt — unparseable or non-mapping frontmatter warns and yields empty metadata while the body still loads. Metadata reads are cached on(path, mtime_ns, size)so exposing descriptions doesn't add a file read per skill per prompt render, and_qualified_skill_file_for_name()returnsPath | Noneinstead of a single-element list so a missing file warns rather than being silently dropped. Skill resolution itself is still recomputed per call, soregister_skill_dir()and precedence/shadowing behave as before.Link to Devin session: https://app.devin.ai/sessions/ba80df57096b414cabe62ae4556b147f
Requested by: @bearsyankees