Local viewer: prominent scan switcher + rename to "pentest" terminology#848
Merged
Conversation
The scan switcher in the top bar was a small, low-contrast button that many users didn't notice or understand. Give it a filled background, a "Scan" label, larger text, and a wider name; widen the dropdown and add a "Switch scan" header so it reads clearly as a scan selector. Rebuilt the committed static bundle.
Contributor
Greptile SummaryThis PR refreshes the local viewer’s pentest terminology and run switcher. The main changes are:
Confidence Score: 5/5The latest changes look safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Add telemetry for feedback, agent steeri..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <div | ||
| className="absolute right-0 z-50 mt-1.5 max-h-80 w-64 overflow-y-auto rounded-lg py-1 shadow-xl" | ||
| style={{ border: "1px solid #2a2a2a", background: "#0a0a0a" }} | ||
| className="absolute right-0 z-50 mt-2 max-h-96 w-96 overflow-y-auto rounded-xl py-1.5 shadow-2xl" |
Contributor
There was a problem hiding this comment.
The fixed w-96 makes the menu 384px wide, so it extends past the left edge of 320px and 375px mobile viewports when opened with right-0. The beginning of each scan name can become inaccessible because the menu has no viewport-aware width limit.
Suggested change
| className="absolute right-0 z-50 mt-2 max-h-96 w-96 overflow-y-auto rounded-xl py-1.5 shadow-2xl" | |
| className="absolute right-0 z-50 mt-2 max-h-96 w-96 max-w-[calc(100vw-1.5rem)] overflow-y-auto rounded-xl py-1.5 shadow-2xl" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: strix/viewer/frontend/src/App.tsx
Line: 438
Comment:
**Dropdown Extends Beyond Mobile Viewport**
The fixed `w-96` makes the menu 384px wide, so it extends past the left edge of 320px and 375px mobile viewports when opened with `right-0`. The beginning of each scan name can become inaccessible because the menu has no viewport-aware width limit.
```suggestion
className="absolute right-0 z-50 mt-2 max-h-96 w-96 max-w-[calc(100vw-1.5rem)] overflow-y-auto rounded-xl py-1.5 shadow-2xl"
```
How can I resolve this? If you propose a fix, please make it concise.Terminology pass on user-facing copy: the Overview nav/tab is now "Pentest Overview", and display strings that said "scan" now say "pentest" (the switcher label + header, empty/running states, run-details "Pentest mode", the re-run CTA, the live-prompt placeholder, and the untitled fallback). API fields and identifiers are unchanged. Rebuilt the committed static bundle.
0xallam
changed the title
- Export-report disclosure button now reads "Export report" (was "Continue with your email" / "Email me the encrypted PDF") to match the page title. - Re-run CTA reads "Re-run in Strix Pro with more depth". Rebuilt the committed static bundle.
Audit of viewer telemetry after the recent changes: - Feedback submissions were untracked. Fire viewer_feedback_submitted server-side in /api/feedback on a successful relay (respects the opt-out; no message/email content is sent). - agent_steered was emitted by the SPA but dropped by the event handler's whitelist. Forward it as viewer_agent_steered. - Opening the upgrade dialog from the sidebar lost its click event when those rows became dialogs; record it via trackCta(slug, "sidebar"). Adds tests for the feedback and agent_steered paths. Rebuilt static bundle.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scan/pentest switcher (top bar)
The switcher was a small, low-contrast button many users didn't notice or realize switched runs.
w-64→w-96), a header, and roomier rows with the target under each entry.Terminology
Rebuilt the committed static bundle.