Skip to content

refactor: move strix/viewer under strix/interface#888

Merged
0xallam merged 2 commits into
mainfrom
devin/1785095685-viewer-under-interface
Jul 26, 2026
Merged

refactor: move strix/viewer under strix/interface#888
0xallam merged 2 commits into
mainfrom
devin/1785095685-viewer-under-interface

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The local run viewer is part of the user interface, so it now lives with the rest of it: strix/viewer/strix/interface/viewer/ (pure git mv, no behavior change).

  • All strix.viewer.* imports become strix.interface.viewer.* (main.py strix view dispatch, TUI viewer launch, tests).
  • Path references updated: pyproject.toml (wheel exclude for the Vite source, ruff per-file-ignores), Makefile viewer target, .gitignore, strix.spec (bundled static/ path), CONTRIBUTING.md.
  • The frontend source and committed static/ bundle move as-is; bundle_dir() is __file__-relative so serving is unchanged.
  • Added # nosec markers on pre-existing bandit findings in the moved/renamed files (the pre-commit bandit hook now rescans them), matching the existing # noqa: S310 # nosec B310 convention.

uv run pytest (417 passed) and pre-commit hooks pass.

Link to Devin session: https://app.devin.ai/sessions/4c3eaf22bc9a4bcc804bd2e434351f84
Requested by: @0xallam

@0xallam 0xallam self-assigned this Jul 26, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR relocates the local viewer package under strix/interface and updates its imports, build paths, packaging configuration, documentation, and tests.

  • Moves the Python viewer package, frontend source, and static bundle without behavioral changes.
  • Updates CLI, TUI, PyInstaller, Hatch, Ruff, Makefile, and test references to the new location.
  • Corrects the auth-cache documentation to match the unchanged runtime path.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported auth-cache documentation mismatch is corrected at the current head.

Important Files Changed

Filename Overview
strix/interface/viewer/auth.py The prior documentation mismatch is fixed; both the module documentation and AUTH_PATH identify ~/.strix/viewer-auth.json.
strix/interface/viewer/server.py Viewer imports were consistently updated to the relocated package without changing server behavior.
strix/interface/viewer/cli.py Internal imports and the frontend build instruction now reference the relocated viewer.
strix/interface/main.py The strix view dispatch imports the CLI from its new package location.
pyproject.toml Wheel exclusions and Ruff overrides were updated to follow the relocated frontend and Python modules.
strix.spec Bundled static assets and hidden imports now reference the relocated viewer package.

Reviews (2): Last reviewed commit: "fix: restore viewer-auth.json path in au..." | Re-trigger Greptile

Comment thread strix/interface/viewer/auth.py Outdated
@0xallam

0xallam commented Jul 26, 2026

Copy link
Copy Markdown
Member

@greptile

@0xallam
0xallam merged commit 589bade into main Jul 26, 2026
1 check passed
@0xallam
0xallam deleted the devin/1785095685-viewer-under-interface branch July 26, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant