Skip to content

Scope viewer session cookie to the bound port - #922

Merged
bearsyankees merged 1 commit into
mainfrom
viewer-per-port-cookie
Jul 28, 2026
Merged

Scope viewer session cookie to the bound port#922
bearsyankees merged 1 commit into
mainfrom
viewer-per-port-cookie

Conversation

@yoni-at-strix

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Scopes viewer session cookies to each server's bound port.

  • Derives the session-cookie name after the HTTP server binds, preventing concurrent localhost viewers from overwriting each other's cookies.
  • Updates session issuance and validation to use the derived cookie name.
  • Adds coverage proving concurrent viewers retain distinct, mutually isolated session cookies.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The port-derived cookie name is assigned before the serving thread starts and is used consistently when issuing and validating sessions, while the new tests cover isolated and combined cookie headers across concurrent servers.

Important Files Changed

Filename Overview
strix/interface/viewer/server.py Derives the session-cookie name from the bound port and consistently uses it for cookie issuance and session validation.
tests/test_viewer.py Updates cookie assertions and adds concurrent-server coverage for cookie-name uniqueness and session isolation.

Reviews (1): Last reviewed commit: "Scope viewer session cookie to the bound..." | Re-trigger Greptile

@bearsyankees
bearsyankees merged commit b313d78 into main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants