fix: calibrate vulnerability severity to demonstrated impact - #962
Merged
Conversation
bearsyankees
marked this pull request as ready for review
August 3, 2026 02:49
Contributor
Greptile SummaryThe PR recalibrates vulnerability reporting around demonstrated impact and makes CVSS calculation failures reject reports rather than fabricate a High score.
Confidence Score: 4/5The contradictory CVSS instructions should be reconciled before merging because they can preserve the reconnaissance-driven severity inflation this PR intends to eliminate. The reporting tool simultaneously requires C:N for reconnaissance-only evidence and instructs agents to assign C:L to account, domain, or version enumeration, which can produce persisted Medium findings without restricted-data disclosure. Files Needing Attention: strix/tools/reporting/tool.py Important Files Changed
Prompt To Fix All With AI### Issue 1
strix/tools/reporting/tool.py:465-468
**Conflicting enumeration impact guidance**
When a reporting agent evaluates account, domain, or software-version enumeration, the later instruction classifies it as `C:L` despite the new requirement that reconnaissance without restricted-data access use `C:N`, causing the observation to be persisted as a Medium finding instead of informational.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix: calibrate vulnerability severity to..." | Re-trigger Greptile |
0xallam
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
info7.5/HighresultWhy
Network reachability, lack of authentication, and reconnaissance value can inflate otherwise low-value observations to Medium when they are incorrectly treated as confidentiality impact. CVSS impact metrics should describe the direct, reasonable consequence demonstrated by the proof of concept, not a hypothetical downstream chain.
This change applies a general evidence-based reporting gate rather than special-casing particular domains or findings.
Validation
uv run ruff check strix/tools/reporting/tool.py tests/test_reporting_tool.pyuv run mypy strix/tools/reporting/tool.pyuv run pytest -q tests/test_reporting_tool.py— 2 passedThe full suite passed before rebasing onto the latest upstream
main(99 passed). On the post-rebase run, an unrelated long-running test did not complete promptly and was stopped; no failure was reported.