feat(reporting): require repo-relative manifest_path on dependency CVE findings - #982
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Greptile SummaryThe PR fixes manifest identity loss during dependency deduplication and requires each new dependency finding to identify its repository-relative manifest.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "feat(report): keep dependency findings f..." | Re-trigger Greptile |
Contributor
Author
0xallam
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_dependency_reportgains amanifest_pathparameter — the repo-relative lockfile/manifest where the vulnerable version was observed (trivy'sTarget, e.g.package-lock.json,services/api/pom.xml) — persisted intodependency_metadata.It is required and validated fail-closed (
_validate_manifest_path): missing/empty, absolute paths, backslashes, drive prefixes, and empty/./..segments are rejected with an actionable error. This binds each SCA finding to its exact file, so downstream remediation (multi-repo scans in particular) can determine the correct repository deterministically instead of probing candidate repos by manifest filename.Dedupe identity now includes the manifest: the same CVE/package observed in two different non-empty
manifest_paths is two findings (one per manifest/workspace), while a missing path on either side keeps the legacy CVE/package/ecosystem identity (_distinct_manifest_pathsinstrix/report/dedupe.py).The
dependency_cve_scanningskill now instructs agents to always fillmanifest_pathfrom trivy'sTarget(stripping any scan-workspace/checkout prefix) and to dedupe per(CVE, PkgName, Target).Tests: required-field and unsafe-path rejection cases, same-vs-distinct-manifest dedupe, plus metadata persistence assertions updated.
Link to Devin session: https://app.devin.ai/sessions/2fedf10aa9244f199f68727957fee746
Requested by: @0xallam