Skip to content

v2.6.6 - rgthree logo route guard removal

Choose a tag to compare

View all tags
@ussoewwin ussoewwin released this 27 Sep 06:13
· 7 commits to main since this release
v2.6.6
58580e1
EN 中文

1. What changed, and why

1.1 Background: why the guard existed

rgthree-comfy serves its node logo from its own routes (/rgthree/logo*.svg). This package added a self-defense guard, patches/rgthree_logo_route_guard.py, in v2.6.4 because rgthree formatted the fetched markup with str.format():

# rgthree-comfy/py/server/routes_config.py (before the upstream fix)
async def get_logo(...):
    svg = await get_logo_svg()
    resp = svg.format(bg=bg, fg=fg)

When the fetched payload was not SVG (a proxy, captive portal or CDN error page), svg.format(...) raised ValueError: unexpected '{' in field name on every request, and the broken payload was cached until restart.

1.2 Why it is no longer needed

The upstream fix, rgthree-comfy#763 ("fix(logo): don't let a non-SVG / proxy error response break the logo route"), contributed by ussoewwin, has been merged (2026-09-25). It changes py/server/routes_config.py (+6/-1) and py/pyproject.py (+22/-2) so the route no longer formats a non-SVG payload.

The installed rgthree-comfy already contains that fix (commit 17f1848 fix(logo): don't let a non-SVG / proxy error response break the logo route, merged into its main), so the guard in this package is redundant.

2. Repository state after this release

Path Change Note
patches/rgthree_logo_route_guard.py DELETED 179 lines removed
__init__.py 13 lines removed the guard's import and apply_rgthree_logo_guard() call block
(other patches, modules, nodes) unchanged -

Remaining patches: patches/nunchaku_patch.py, patches/transformers_image_processor_kwargs_patch.py, patches/transformers_qwen_vl_docstring_patch.py.

3. What was verified

  • No remaining references to the removed module anywhere in the code base (search over all .py files).
  • Syntax check of __init__.py passes.
  • The diff is limited to the two items above; no other file was touched.
  • The runtime copy under custom_nodes/ComfyUI-QwenImageLoraLoader/ was updated: the patch file is gone, only the three remaining patches are present, and no references remain.
  • The installed rgthree-comfy contains the upstream fix (17f1848).

4. Action required

  • Nothing for users: update rgthree-comfy via ComfyUI Manager as usual so it includes upstream #763.
  • Restart ComfyUI to load the updated __init__.py from the runtime copy.

5. Notes

  • QIL_DISABLE_RGTHREE_LOGO_GUARD no longer has any effect, because the guard it controlled has been removed.
  • The v2.6.4 release notes and the technical guide md/RGTHREE_LOGO_GUARD_AND_SAM3_PATCH_REMOVAL.md remain as historical records.

6. Links

Assets 2
Loading