Skip to content

パンチエフェクトのバグを修正 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazukinumazato merged 1 commit into from
Nov 19, 2022
Merged

パンチエフェクトのバグを修正 #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/web/src/component/game.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,11 +449,17 @@ class PunchAction implements FighterAction {

isCompleted = false;

isSucceeded = false;

requiredStamina = 20;

constructor(actor: Fighter, target: Fighter) {
this.actor = actor;
this.target = target;
const distance = calculateDistance(this.actor, this.target);
if (distance <= Fighter.armLength) {
this.isSucceeded = true;
}
}

tick() {
Expand Down Expand Up @@ -876,7 +882,7 @@ class WorldRenderer {
if (action instanceof PunchAction) {
const existingRenderer = this.punchEffectRenderers.get(action);
if (!existingRenderer) {
if (!action.isCompleted) {
if (!action.isCompleted && action.isSucceeded) {
const newRenderer = new PunchEffectRenderer(action, this.#pixi);
this.punchEffectRenderers.set(action, newRenderer);
newRenderer.onCompleted = () => {
Expand Down