Restore SonarCloud#147
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe changes tighten CUDA and serialization validation, restore SonarCloud configuration, alter Logger and Matrix special members, restrict POSIX test-directory permissions, and add unit coverage for invalid serialized data. ChangesTooling and CI
Core utility APIs
Serialization validation
Manual test filesystem permissions
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant Serialize
participant FlatBuffers
participant Deserialize
participant Array1
Caller->>Serialize: provide payload
Serialize->>FlatBuffers: build FlatData
Caller->>Deserialize: provide serialized buffer
Deserialize->>FlatBuffers: verify and extract payload
Deserialize->>Array1: assign validated bytes
Deserialize-->>Caller: return or invalid_argument
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.sonarcloud.properties:
- Line 2: Update the sonar.exclusions setting in .sonarcloud.properties to use
an automatic-analysis-compatible explicit directory or file path for the
generated Flatbuffers sources, or remove the recursive wildcard from this file
and configure that exclusion in SonarCloud analysis-scope settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c968318a-9ca4-4fba-9347-eb221c55a08a
📒 Files selected for processing (10)
.github/workflows/scripts/actions/install_cuda_ubuntu.sh.sonarcloud.propertiesIncludes/Core/Matrix/Matrix.hppIncludes/Core/Utils/Logging.hppIncludes/Core/Utils/Parallel-Impl.hppIncludes/Core/Utils/Serialization-Impl.hppSources/Core/Utils/Serialization.cppTests/ManualTests/ManualTests.hppTests/UnitTests/Array1Tests.cppTests/UnitTests/Vector3Tests.cpp
📜 Review details
⏰ Context from checks skipped due to timeout. (17)
- GitHub Check: CodeRabbit
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: 🪟 CUDA Build - Windows Server 2025 + Visual Studio 2026 + CUDA 13.2.0 (Release)
- GitHub Check: 🪟 CUDA Build - Windows Server 2022 + Visual Studio 2022 + CUDA 12.6.3 (Release)
- GitHub Check: 🐧 CUDA Build - Ubuntu 24.04 + gcc-12 + CUDA 12.6.3
- GitHub Check: 🪟 Build - Windows Server 2025 + Visual Studio 2026
- GitHub Check: 🪟 Build - Windows Server 2022 + Visual Studio 2022
- GitHub Check: 🧪 Code Coverage - Codecov (Ubuntu 24.04 + gcc-14, ubuntu-24.04, gcc, 14)
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-18
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-13
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-16
- GitHub Check: 🍎 Build - macOS 26.3 + Xcode 26.3
- GitHub Check: 🍎 Build - macOS 15.7.4 + Xcode 16.4
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-12
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-17
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-14
🔇 Additional comments (12)
Includes/Core/Utils/Serialization-Impl.hpp (1)
15-45: LGTM!Tests/UnitTests/Vector3Tests.cpp (1)
5-10: LGTM!Sources/Core/Utils/Serialization.cpp (1)
15-15: LGTM!Also applies to: 29-34, 52-73
Tests/UnitTests/Array1Tests.cpp (1)
144-170: LGTM!Includes/Core/Matrix/Matrix.hpp (1)
351-357: LGTM!Also applies to: 908-908
Includes/Core/Utils/Logging.hpp (1)
60-68: LGTM!Also applies to: 133-133
Includes/Core/Utils/Parallel-Impl.hpp (2)
128-132: LGTM!
51-81: 🎯 Functional CorrectnessNo issue here:
Internal::Asyncis only used to wait for completion, and no call site consumes a task result orget().> Likely an incorrect or invalid review comment..github/workflows/scripts/actions/install_cuda_ubuntu.sh (1)
29-35: LGTM!Also applies to: 44-50, 81-90, 161-161
.sonarcloud.properties (2)
1-1: LGTM!
3-3: 🎯 Functional CorrectnessC++17 override matches the build standard.
CXX_STANDARDis set to 17, and CUDA also uses--std=c++17.Tests/ManualTests/ManualTests.hpp (1)
35-35: LGTM!Also applies to: 179-179
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 84.36% 84.47% +0.10%
==========================================
Files 460 460
Lines 32468 32518 +50
Branches 2799 2803 +4
==========================================
+ Hits 27393 27470 +77
+ Misses 5075 5048 -27 🚀 New features to boost your workflow:
|
utilForever
force-pushed
the
sonarcloud
branch
3 times, most recently
from
1150547 to
fffbdbd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Includes/Core/Matrix/Matrix.hpp`:
- Around line 70-76: Update the Matrix<T, 3, 1> specialization’s copy/move
constructors and assignment operators to be explicitly defaulted, matching the
primary Matrix definition and preserving noexcept qualifiers, so Vector3 aliases
remain trivially copyable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dee37c33-a27f-4a20-9641-6b3524c91e96
📒 Files selected for processing (1)
Includes/Core/Matrix/Matrix.hpp
📜 Review details
⏰ Context from checks skipped due to timeout. (16)
- GitHub Check: CodeRabbit
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: 🪟 CUDA Build - Windows Server 2025 + Visual Studio 2026 + CUDA 13.2.0 (Release)
- GitHub Check: 🪟 CUDA Build - Windows Server 2022 + Visual Studio 2022 + CUDA 12.6.3 (Release)
- GitHub Check: 🐧 CUDA Build - Ubuntu 24.04 + gcc-12 + CUDA 12.6.3
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-14
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-12
- GitHub Check: 🐧 Build - Ubuntu 24.04 + gcc-13
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-18
- GitHub Check: 🧪 Code Coverage - Codecov (Ubuntu 24.04 + gcc-14, ubuntu-24.04, gcc, 14)
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-17
- GitHub Check: 🐧 Build - Ubuntu 24.04 + clang-16
- GitHub Check: 🍎 Build - macOS 15.7.4 + Xcode 16.4
- GitHub Check: 🍎 Build - macOS 26.3 + Xcode 26.3
- GitHub Check: 🪟 Build - Windows Server 2025 + Visual Studio 2026
- GitHub Check: 🪟 Build - Windows Server 2022 + Visual Studio 2022
🔇 Additional comments (1)
Includes/Core/Matrix/Matrix.hpp (1)
70-76: 🎯 Functional CorrectnessNo issue here.
MatrixExpressionandMatrixDenseBaseare stateless, so the defaulted copy/move operations onMatrix<T, Rows, Cols>do not change behavior beyond copyingm_elements.> Likely an incorrect or invalid review comment.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 participants
This revision includes:
Summary by CodeRabbit
std::invalid_argumenton bad inputs and safely clearing/handling outputs.Matrixcopy/move special member implementations.