Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR represents a major version bump from 1.7.15 to 2.0.0, modernizing the mendly utility library with significant infrastructure and structural improvements. The changes migrate from legacy tooling (Jest, TSLint, CircleCI) to modern alternatives (Vitest, ESLint, GitHub Actions) while restructuring the codebase into a flatter architecture with improved TypeScript configurations for both ESM and CommonJS output.
Key changes:
- Migration from Jest to Vitest with improved coverage thresholds
- Replacement of TSLint with ESLint and Prettier for code quality
- Restructuring from nested
source/directory to flat root structure with organized subdirectories - Updated build system supporting dual ESM/CJS output with proper package.json exports
- Modernized TypeScript configuration with stricter type checking
Reviewed Changes
Copilot reviewed 120 out of 123 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | New Vitest configuration with coverage thresholds and test settings |
| tsconfig.json | Main TypeScript config with trailing comma syntax error |
| tsconfig.mjs.json | ESM-specific TypeScript configuration |
| tsconfig.cjs.json | CommonJS-specific TypeScript configuration |
| package.json | Updated dependencies, scripts, and dual module system exports |
| index.ts | New root entry point with namespace-based exports |
| Writer/File.ts | File writer implementation with incorrect fs.write API usage |
| Uri/index.parse.spec.ts | URI parsing tests with "schemaless" typo |
| .eslintrc | New ESLint configuration replacing TSLint |
| .github/workflows/* | GitHub Actions CI/CD replacing CircleCI |
Comments suppressed due to low confidence (1)
Uri/index.parse.spec.ts:111
- The word "schemaless" is misspelled. The correct spelling is "schemeless" (referring to lacking a scheme).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@simonmika I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@simonmika I've opened a new pull request, #12, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix fs.write signature to use string overload with utf8 encoding Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
* Initial plan * Fix unused initial value in Writer/File.ts writeImplementation Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> * Fixed issues with fs.write signatures. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com> Co-authored-by: Simon Mika <simonmika@users.noreply.github.com> Co-authored-by: Simon Mika <simon@mika.se>
Breaking changes.