Skip to content

Fix fs.write signature to use string overload instead of Buffer#11

Merged
simonmika merged 2 commits intomaster-2from
copilot/sub-pr-10
Nov 6, 2025
Merged

Fix fs.write signature to use string overload instead of Buffer#11
simonmika merged 2 commits intomaster-2from
copilot/sub-pr-10

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

Addresses review feedback on incorrect fs.write usage in Writer/File.ts.

Changes

  • Remove unnecessary Buffer conversion: Pass string directly instead of Buffer.from(string)
  • Use string overload signature: fs.write(fd, string, position, encoding) instead of fs.write(fd, buffer, offset, length, position)
  • Fix position parameter: Use null to append at current file position instead of 0 which overwrites
// Before
const content = Buffer.from(buffer.reduce((r, item) => r + item, ""))
const r = await fs.write(this.descriptor, content, 0, content.length)

// After
const content = buffer.reduce((r, item) => r + item, "")
const r = await fs.write(this.descriptor, content, null, "utf8")

The position 0 was causing each write to overwrite the file from the beginning, breaking multiline writes.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
@simonmika simonmika marked this pull request as ready for review November 6, 2025 11:30
Copilot AI changed the title [WIP] WIP address feedback from review for refactoring Fix fs.write signature to use string overload instead of Buffer Nov 6, 2025
Copilot AI requested a review from simonmika November 6, 2025 11:30
@simonmika simonmika merged commit 89fc6eb into master-2 Nov 6, 2025
8 checks passed
@simonmika simonmika deleted the copilot/sub-pr-10 branch November 6, 2025 11:30
simonmika added a commit that referenced this pull request Nov 6, 2025
* Updated configuration.

* Further cleanup.

* Fixed compile issues.

* Fixed remaining compile issues.

* Renamed test files.

* Full verification suite works.

* Breaking change, changed from isEmpty to empty.

* Modernized exports.

* Fixed remaining export import issues.

* Improved structure of Uri class.

* Improved Error.

* Fixed String.

* Removed String as it did not add significant value.

* Fixed Enumerator exports.

* Fixed file name of Enumerator.

* Fixed Device naming.

* Refactored Reader and Writer.

* Fix fs.write signature to use string overload instead of Buffer (#11)

* Initial plan

* Fix fs.write signature to use string overload with utf8 encoding

Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>

* Remove unused initial value in Writer/File.ts writeImplementation (#12)

* Initial plan

* Fix unused initial value in Writer/File.ts writeImplementation

Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>

* Fixed issues with fs.write signatures.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
Co-authored-by: Simon Mika <simonmika@users.noreply.github.com>
Co-authored-by: Simon Mika <simon@mika.se>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: simonmika <1467077+simonmika@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants