fix: match app language of the string resource in SteamService - #1817
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughWalkthrough
ChangesLocale-aware service context
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change makes SteamService display string resources in the app-selected language instead of the device language; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks good and nicely aligned with legendary. Main issue: the keep-alive doesn't actually save the exit sync. It runs in viewModelScope, so swiping the app away cancels it anyway and now EpicService is left running with nothing to stop it. The sync needs to run in a scope that outlives the ViewModel (e.g. the service's own scope), with the service stopping itself when work finishes. Also, downloadChunksParallel holds every decompressed chunk in memory. for the save-heavy games this targets that's an OOM risk. In resolveConflict you only need the chunks referenced by toDownload files, and checking completeness against just those also stops downloadSuccess going false (and the sync timestamp never updating) over chunks we didn't need. |
…omendações (utkarshdalal#1828), download externo (utkarshdalal#1785), idioma (utkarshdalal#1817), popups (utkarshdalal#1827), README (utkarshdalal#1826) Conflitos resolvidos: - README.md: mantém o README do fork (atribuição librashader + build do fork) - LibraryScreen.kt: mantém os dois imports (Dispatchers + PostHog) - LibraryListCard.kt: combina o teaser de recomendação do upstream (utkarshdalal#1828) com os badges do fork (ShaderActiveBadge/ProfileOverrideBadge, specs M4/E) — badges só em jogos reais, teaser mostra o ícone AutoAwesome Verificado arquivo por arquivo: nenhum arquivo de shader ou gamepad é alterado por este merge (catalog.json, VulkanLibrashader, PerGameShaderStore, hub de gamepad intactos). LSFG (utkarshdalal#1822): liblsfg-vk-layer.so movida de assets/ para jniLibs; LsfgVkManager reconciliado (cópia de nativeLibraryDir, manifest segue em assets). Intermediário stale de assets limpo (gotcha AGENTS.md) — APK contém uma única cópia da .so. Validação: assembleModernDebug OK (3 ABIs librashader), 218 testes JVM verdes.
Description
Since #1775 , downloadInfo is now showing the depot information from string resources, when the OS is chinese and the app is english, it will show chinese in the string. This fix it to match app language to SteamService.
Recording
screen-20260814-234155.1.mp4
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Applies the app-selected language in SteamService during attachBaseContext so its string resources (e.g., downloadInfo/depot text) follow the app locale instead of the device locale. Previously, with OS Chinese and app English, downloadInfo used the OS language; now it matches the app.
Written for commit de203c3. Summary will update on new commits.
Summary by CodeRabbit