test : added unit tests for RateLimiter and WorkflowRateLimiter helpers#1228
Merged
Conversation
utksh1
added a commit
that referenced
this pull request
Jun 25, 2026
, #1234, #1232, #1231, #1230, #1229, #1228, #1222, #1221, #1254, #1252, #1251, #1250, #1242, #1255, #1090, #1097, #1112) Reverting all PR merges performed during this session to restore repository to pre-session state. This reverts commits: - e376276 (#1255) - 18e5101 (#1222) - e516dd5 (#1230) - be400fa (#1235) - d522e9a (#1243) - bc0b1cd (#1090) - de56660 (#1097) - c2a5a53 (#1112) - eb30d33 (#1254) - f2a67f7 (#1250) - 6579112 (#1251) - 8751d92 (#1252) - 3ebc935 (#1221) - 6f5a936 (#1228) - da15da4 (#1229) - b66a5b0 (#1231) - 775c5c2 (#1232) - b529ddb (#1234) - 965b001 (#1241) - d46e573 (#1242) - dd09955 (#1240) All PRs are also being reopened and gssoc labels removed.
utksh1
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1223.
Summary of What Has Been Done:
Created testing/backend/unit/test_ratelimit.py covering the RateLimiter and WorkflowRateLimiter helpers from backend.secuscan.ratelimit. These are genuinely uncovered by test_endpoint_rate_limiter.py (which covers EndpointRateLimiter and resolve_client_identity).
Changes Made:
Impact it Made:
Zero test coverage for the core per-client rate limiter and the workflow scheduler rate limiter. Bugs in quota accounting or bucket isolation would silently allow rate limit bypasses. This brings ratelimit module unit test coverage to ~90%.
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.