Skip to content

Fix #1489: Type-Unsafe Request Payloads (Missing Pydantic Models)#1517

Open
sahare-mayur-0071 wants to merge 4 commits into
utksh1:mainfrom
sahare-mayur-0071:fix/1489
Open

Fix #1489: Type-Unsafe Request Payloads (Missing Pydantic Models)#1517
sahare-mayur-0071 wants to merge 4 commits into
utksh1:mainfrom
sahare-mayur-0071:fix/1489

Conversation

@sahare-mayur-0071

Copy link
Copy Markdown
Contributor

Fixes #1489

@utksh1 utksh1 added level:advanced 55 pts difficulty label for advanced contributor PRs type:refactor Refactor work category bonus label type:bug Bug fix work category bonus label priority:medium Important issue with normal urgency area:backend Backend API, database, or service work labels Jul 1, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off on merging this one. A couple of issues to address first:

  1. Encoding/mojibake corruption — the diff introduces broken characters in two existing comments (ΓÇö where an em-dash used to be) in routes.py. This injects garbage bytes and must be reverted to the original UTF-8.
  2. Overlap with other PRs — the type-safety refactor here spans the same target-policy / workflow / credential / session endpoints covered by the more focused #1514, #1515, and #1516 (now merged). Please rebase onto current main and resolve the inevitable conflicts, and consider narrowing scope to whatever isn't already covered.

Once the mojibake is fixed and it's rebased, happy to take another look.

@sahare-mayur-0071

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I've fixed the mojibake encoding issue in
outes.py and successfully rebased the branch on main to resolve merge conflicts and overlap with the recently merged PRs. It's ready for another look.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I've reviewed the proposal and it looks like a valid addition. However, this branch currently has Git merge conflicts with main. Could you please pull the latest changes from upstream, resolve the conflicts, and push the rebased branch so we can continue the review process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Backend API, database, or service work level:advanced 55 pts difficulty label for advanced contributor PRs priority:medium Important issue with normal urgency type:bug Bug fix work category bonus label type:refactor Refactor work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Type-Unsafe Request Payloads (Missing Pydantic Models)

2 participants