Skip to content

fix(pack-api): correctly calculate module size in webpack stats - #2495

Merged
xusd320 merged 1 commit into
nextfrom
fix/webpack-stats-size-calculation
Jan 7, 2026
Merged

fix(pack-api): correctly calculate module size in webpack stats#2495
xusd320 merged 1 commit into
nextfrom
fix/webpack-stats-size-calculation

Conversation

@xusd320

@xusd320 xusd320 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Directly read on VitualFileSystem will cause panic.
image

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the pack-api component where the reported module size in webpack statistics was inaccurate. The changes ensure that module sizes are now correctly calculated by inspecting the actual file content, providing more reliable data for build analysis and optimization.

Highlights

  • Module Size Calculation Fix: Corrected the logic for calculating module sizes within webpack stats to ensure accuracy. Previously, the size was incorrectly derived, leading to potentially misleading statistics.
  • Content-Based Size Determination: The module size is now accurately determined by reading the actual content length of the file, rather than an erroneous method that did not reflect the true size.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the calculation of module sizes for webpack stats. The previous implementation was not robust and could lead to errors when reading file content. The new implementation correctly calculates the module size as an Option<u64>, gracefully handling potential read errors or cases where content is not available by setting the size to None. This change improves the resilience of the webpack stats generation. The fix is well-implemented using idiomatic Rust.

@xusd320
xusd320 requested a review from fireairforce January 7, 2026 06:49
@xusd320
xusd320 merged commit cad438f into next Jan 7, 2026
21 checks passed
@xusd320
xusd320 deleted the fix/webpack-stats-size-calculation branch January 7, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants