get sum and related tests#60
Merged
eldadfux merged 7 commits intoutopia-php:mainfrom Aug 18, 2021
lohanidamodar:feat-get-sum
Merged
get sum and related tests#60eldadfux merged 7 commits intoutopia-php:mainfrom lohanidamodar:feat-get-sum
eldadfux merged 7 commits intoutopia-php:mainfrom
lohanidamodar:feat-get-sum
Conversation
kodumbeats
suggested changes
Aug 17, 2021
Co-authored-by: kodumbeats <brandon.leckemby@gmail.com>
Co-authored-by: kodumbeats <brandon.leckemby@gmail.com>
eldadfux
approved these changes
Aug 18, 2021
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Nothing to add on top of @kodumbeats comments.
Contributor
Author
Fixed, mongodb sum and updated the tests and comments as requested. |
eldadfux
requested changes
Aug 18, 2021
Contributor
Author
|
@eldadfux updated fixed the naming issue in the tests |
eldadfux
approved these changes
Aug 18, 2021
kodumbeats
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new method to get sum of an attribute