Merged
Conversation
Contributor
|
Could this be where the extra slash is being added in the beginning? |
Contributor
Author
yes, I believe so. I feel that's a better place to remove the slash , instead of trimming it. what do you think @lohanidamodar @eldadfux ? |
Contributor
Author
|
Also the tests pass locally , they fail in Travis CI because of the expired credentials of various providers. Need help in updating them as I do not have access to it. |
1 task
Contributor
|
Please sync your branch with |
christyjacob4
requested changes
Dec 6, 2022
Contributor
christyjacob4
left a comment
There was a problem hiding this comment.
We need to also update the local device adapter to adhere to these changes.
christyjacob4
approved these changes
Dec 8, 2022
Contributor
|
Awesome work @everly-gif 😄 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim extra slashes before passing root.
Doing this because it creates an extra
/while integrating with Appwrite.for eg , a call as below was being made.
https://<bucket-name>.eu-central-1.linodeobjects.com**//**storage/uploads/app-630cd8d7a106aa302d27/630cd8e90d3b33e8ff5c/6/3/0/c/630cdc2875416374d993.jpgThe root within Appwrite are already prefixed with
/(seen as below). Hence, we need to trim it here to avoid double slashes.This PR implements trimming the root in the constructor.