Return total & allow pagination in searchRepositories.

[hmacr]

Related SER-504

Summary by CodeRabbit

• Bug Fixes

  • Repository search now accepts a page parameter for pagination and returns both the list of results and the total number of matches.

• Tests

  • Tests updated to validate pagination and total-count behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The GitHub adapter's searchRepositories method now sends a page query parameter with the API request and changes its return shape: instead of returning only the items array it returns an associative structure with items and total (mapped from the API response's total_count). Tests were updated to destructure the returned value and assert the new total field in addition to item assertions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Inspect src/VCS/Adapter/Git/GitHub.php to confirm the page parameter is encoded and included in the request.
• Verify response handling maps total_count to total and preserves items.
• Review tests/VCS/Base.php to ensure assertions match the new return shape.
• Search for other callers of searchRepositories and note they may require updates to handle the associative return value.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly and specifically describes the main changes: returning a total value and adding pagination support to the searchRepositories method.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ser-504

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab384b8 and 2d61d8f.

📒 Files selected for processing (1)

• tests/VCS/Base.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/VCS/Base.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}