Skip to content

Return total & allow pagination in searchRepositories. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Meldiron merged 3 commits into from
Nov 28, 2025
Merged

Return total & allow pagination in searchRepositories. #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
153136e
Return total from searchRepositories function
hmacr Nov 25, 2025
089a340
set page
hmacr Nov 25, 2025
2d61d8f
test
hmacr Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/VCS/Adapter/Git/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public function searchRepositories(string $owner, int $page, int $per_page, stri

$response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"], [
'q' => "{$search} user:{$owner} fork:true",
'page' => $page,
'per_page' => $per_page,
'sort' => 'updated'
]);
Expand All @@ -118,7 +119,10 @@ public function searchRepositories(string $owner, int $page, int $per_page, stri
throw new Exception("Repositories list missing in the response.");
}

return $response['body']['items'];
return [
'items' => $response['body']['items'],
'total' => $response['body']['total_count'],
];
}

/**
Expand Down
3 changes: 2 additions & 1 deletion tests/VCS/Base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ public function testGetOwnerName(): void

public function testSearchRepositories(): void
{
$repos = $this->vcsAdapter->searchRepositories('test-kh', 1, 2);
['items' => $repos, 'total' => $total] = $this->vcsAdapter->searchRepositories('test-kh', 1, 2);
$this->assertCount(2, $repos);
$this->assertSame(6, $total);
}

public function testCreateComment(): void
Expand Down