-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Re-enable unused_qualifications lint #10571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently tested in linux environment and wanted to test if this fails in CI
|
GNU testsuite comparison: |
|
Some jobs are sad |
|
Hahahahahahaha mhmmm, I'll push a fix in a bit |
670b9a3 to
ad88105
Compare
|
GNU testsuite comparison: |
c5d25d4 to
a7a0347
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
651f901 to
40e53e4
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
Looks like #10442 |
|
Overall, the changes look fine to me, but since in some cases the qualification might have been added to improve readability, we should consider those instances carefully. |
e20765d to
4df9e71
Compare
4df9e71 to
ad00954
Compare
|
GNU testsuite comparison: |
|
broke CI: |
|
Yes, apparently this PR was considered stale and was merged. I'll follow up a fix |
|
@sylvestre Is it time to use a merge queue to prevent this kind of issue? |
|
it isn't a big deal :) |
Summary
This PR re-activates the
unused_qualificationslint by setting it back towarnin the lint config:Motivation
unused_qualificationshad been commented out due to warnings inuucore. Those warnings have now been addressed, so we can restore the lint to catch future regressions.Testing
Notes
If CI reports platform-specific warnings or toolchain differences, I’ll follow up with fixes or adjust the lint scope as needed.