rm: hint to use ./-foo when removing a dash-prefixed file

[sylvestre]

No description provided.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/pid-pipe (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/dash-hint is no longer failing!

[cakebaker]

I don't know if you have seen it: the new test fails on Windows with:

thread 'test_rm::test_dash_hint' (9316) panicked at tests\uutests\src\lib\util.rs:1161:39:
    called `Result::unwrap()` on an `Err` value: Os { code: 123, kind: InvalidFilename, message: "The filename, directory name, or volume label syntax is incorrect." }

[codspeed-hq]

Merging this PR will degrade performance by 3.06%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 322 untouched benchmarks
⏩ 46 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	du_max_depth_balanced_tree[(6, 4, 10)]	25.2 ms	26 ms	-3.06%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing sylvestre:rm-gnu-dash-hint-test (3335656) with main (533edad)²}

Footnotes

1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (4353689) during the generation of this report, so 533edad was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[collinfunk]

I find it a bit annoying that my review was ignored. I wrote the tests/rm/dash-hint.sh test under GPLv3+, and this pull request is essentially a verbatim copy of it.

[sylvestre]

sorry, i didn't see your review
where did you share it ?

[collinfunk]

My fault. GitHub isn't clear who "Pending" is waiting on approval from the submitter or maintainer. In this case it was me, the submitter.

Anyways, I have noticed this is one of a few pull requests I have noticed recently which has contained verbatim copies of tests from GNU coreutils.

[sylvestre]

Anyways, I have noticed this is one of a few pull requests I have noticed recently which has contained verbatim copies of tests from GNU coreutils.

I will make sure it doesn't happen again
(you are probably aware but some tests in GNU coreutils are coming from me too :)

[collinfunk]

Anyways, I have noticed this is one of a few pull requests I have noticed recently which has contained verbatim copies of tests from GNU coreutils.

I will make sure it doesn't happen again (you are probably aware but some tests in GNU coreutils are coming from me too :)

Yes, which is why I checked the author first. In this case, I was the sole author of the test. The copyright assignment allows you freedom to do what you wish with your own work; search "grantback" on this page [1].

I find it a bit frustrating to see this repeated multiple times, though, after I warned about it here [2].

[1] https://www.fsf.org/bulletin/2022/fall/copyright-assignment-with-the-fsf
[2] #12136 (comment)

[sylvestre]

yeah, sorry again :(

(i did the copyright assignment to the FSF for gcc 10+ years ago)