Skip to content

install: dedup id resolution and make root test robust#12680

Open
sylvestre wants to merge 2 commits into
uutils:mainfrom
sylvestre:test_install_root_combined
Open

install: dedup id resolution and make root test robust#12680
sylvestre wants to merge 2 commits into
uutils:mainfrom
sylvestre:test_install_root_combined

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

No description provided.

@sylvestre sylvestre force-pushed the test_install_root_combined branch from 2820545 to 82ba7ae Compare June 7, 2026 19:54
Comment thread src/uu/install/src/install.rs Outdated
Comment on lines 334 to 341
@@ -339,6 +339,16 @@ pub fn uu_app() -> Command {
///
/// In event of failure, returns an integer intended as a program return code.
///

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the comment belongs to the behavior function.

@sylvestre sylvestre force-pushed the test_install_root_combined branch from 82ba7ae to 51d9f5a Compare July 4, 2026 16:36
@codspeed-hq

codspeed-hq Bot commented Jul 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing sylvestre:test_install_root_combined (9d6476b) with main (4430794)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

Moved documentation for the behavior function to a new location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants