du: do not deduplicate --files0-from / operand names by name#12750
Open
sylvestre wants to merge 2 commits into
Open
du: do not deduplicate --files0-from / operand names by name#12750sylvestre wants to merge 2 commits into
sylvestre wants to merge 2 commits into
Conversation
Merging this PR will improve performance by 4.88%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
Contributor
|
I don't know if you have seen it: the changes break the |
GNU du deduplicates only by inode during traversal (disabled by
--count-links); it never collapses repeated operand names. uutils du
removed duplicate names from both read_files_from() and the plain
operand list, which produced two GNU-visible divergences in
tests/du/files0-from.pl:
- 'du -l --files0-from' with a file listed twice printed it once
instead of twice (-l must disable dedup).
- repeated missing files reported a single error instead of one per
occurrence (missing files have no inode to dedup on).
Drop the name-based dedup in both places and rely on the existing
inode-based dedup in the traversal loop, matching GNU. This also fixes
the plain-operand case 'du missing missing'.
Fixes tests/du/files0-from.pl.
Windows CreateFile rejects opening a directory for a plain read handle, so get_file_info()/get_blocks() always returned no inode for directories, silently disabling inode-based dedup there. This was previously masked by name-based operand dedup; removing that dedup exposed it, breaking test_du_deduplicated_input_args on Windows CI.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tests/du/files0-from.pl.