nohup: report command execution errors - #13391
Merged
Merged
Conversation
|
GNU testsuite comparison: |
Contributor
Author
|
Hi, just a gentle ping in case this got buried. When you have a chance, could you please take a look? Thanks! |
Contributor
|
Please be patient. We have a long backlog |
Contributor
Author
|
Understood — apologies for the premature ping, and thank you for taking the time to review and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12693.
nohupused the error returned byexeconly to select the exit status, without reporting why the command could not be started.Display the underlying execution error before returning, matching GNU's diagnostic while preserving the existing exit codes.
strip_errnoremoves Rust's platform-specific(os error N)suffix.Extend the existing command-not-found test to check the diagnostic.