Skip to content

cargo: move lints section after dependencies and features - #13715

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:cargo-order-lints
Aug 2, 2026
Merged

cargo: move lints section after dependencies and features#13715
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:cargo-order-lints

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Reorder the cargo manifest so that the [lints] section is emitted after the [dependencies] and [features] sections.

This ordering better matches the structure commonly seen in Rust projects.

No functional changes; this is purely a reordering of manifest sections.

@xtqqczze
xtqqczze force-pushed the cargo-order-lints branch from ef8cbd4 to a48c470 Compare August 2, 2026 09:37
Reorder the cargo manifest so that the `[lints]` section is emitted after the `[
dependencies]` and `[features]` sections.

This ordering better matches the structure commonly seen in Rust projects.

No functional changes; this is purely a reordering of manifest sections.
@xtqqczze
xtqqczze force-pushed the cargo-order-lints branch from a48c470 to eead0f8 Compare August 2, 2026 11:16
Comment on lines +50 to +51
[lints]
workspace = true

@cakebaker cakebaker Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that the section is at the end of the file? In the other files the lints section is followed by the bin section.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so it can follow [dev-dependencies]. I wanted to avoid too many changes in this PR, but the [[bin]] section should be reordered too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I ignore them :)

Comment thread src/uu/id/Cargo.toml
Comment on lines +36 to +37
[lints]
workspace = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment thread src/uu/join/Cargo.toml
Comment on lines +35 to +36
[lints]
workspace = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that the lints section is not followed by the bin section?

Comment thread src/uu/ls/Cargo.toml
Comment on lines +68 to +69
[lints]
workspace = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that the lints section is at the end of the file?

Comment thread src/uu/more/Cargo.toml
Comment on lines +37 to +38
[lints]
workspace = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@cakebaker
cakebaker merged commit 670aeef into uutils:main Aug 2, 2026
168 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants