Skip to content

od: remove enum var not used at production - #13738

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:od-stream
Aug 4, 2026
Merged

od: remove enum var not used at production#13738
cakebaker merged 1 commit into
uutils:mainfrom
oech3:od-stream

Conversation

@oech3

@oech3 oech3 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.21%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 573.2 µs 699.4 µs -18.04%
Simulation cksum_multiple_files 60.6 ms 63 ms -3.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:od-stream (0d8372c) with main (46cf6db)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
oech3 force-pushed the od-stream branch 2 times, most recently from 335003d to 0d8372c Compare August 4, 2026 09:36
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/sparse-to-pipe is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@cakebaker
cakebaker merged commit 61cac11 into uutils:main Aug 4, 2026
165 of 167 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3
oech3 deleted the od-stream branch August 4, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants