fix: accept vertical tab and form feed as whitespace between tokens - #322
Conversation
Merging this PR will degrade performance by 3.24%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | parse_extended_large_year |
36.4 µs | 37.6 µs | -3.32% |
| ❌ | parse_date_only |
37.9 µs | 39.1 µs | -3.19% |
| ❌ | parse_extended_year |
36.3 µs | 37.5 µs | -3.19% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wtcpython:accept-vertical-tab-whitespace (a965856) with main (4cf4db3)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 21 21
Lines 4061 4075 +14
Branches 129 129
=======================================
+ Hits 4034 4048 +14
Misses 26 26
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The perf regression are acceptable |
GNU date accepts
\vand\fas whitespace between items, but winnow'smultispace0/multispace1do not, so inputs likeJan 23\v 2026 1:00AMare rejected (uutils/coreutils#13864). Replace them with local parsers covering the full ASCII whitespace set.