release: give the build container the tools the workflow needs - #285
Merged
Conversation
The 0.3.1 pipeline failed before it compiled anything: a bare ubuntu:22.04 has no git, and the generated workflow runs `git config` as its first step, then installs Rust with curl. buildpack-deps:22.04 carries git, curl and a C toolchain, is still Ubuntu 22.04, and produces the same GLIBC_2.34 floor -- verified by building in it and dumping the versioned symbols, and by running the result on a glibc 2.35 host. No release was published for the 0.3.1 tag, so the tag is moved rather than the version burned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.3.1 pipeline failed before it compiled anything:
A bare
ubuntu:22.04has nogit, and the generated workflow runsgit configas its very first step, then installs Rust with
curl. The apt dependenciesdeclared in
dist-workspace.tomlare installed later, so they cannot help.buildpack-deps:22.04carries git, curl and a C toolchain, is still Ubuntu22.04, and produces the same floor. Verified by building in it and dumping the
versioned symbols, and by running the result on a glibc 2.35 host:
No release was published for the
0.3.1tag —hostandannouncewereskipped — so the tag moves rather than the version being burned.