Skip to content

Updates to Schemas and Flask for ActivitySchedule Documents - #360

Merged
jayfo merged 24 commits into
uwscope:developfrom
anantmittal:activity-schedule-schemas
Oct 15, 2022
Merged

Updates to Schemas and Flask for ActivitySchedule Documents#360
jayfo merged 24 commits into
uwscope:developfrom
anantmittal:activity-schedule-schemas

Conversation

@anantmittal

Copy link
Copy Markdown
Collaborator

No description provided.

@anantmittal
anantmittal requested a review from jayfo September 30, 2022 17:53
@uwscope uwscope deleted a comment from anantmittal Sep 30, 2022
Added activity (template) schema

Changed activityId to activityScheduleId in scheduled-activity.json

Changed  schema to

Removed activity name field from activity-schedule and scheduled-activity schema
@anantmittal
anantmittal force-pushed the activity-schedule-schemas branch from 2d4cbc1 to a0596f8 Compare September 30, 2022 19:40
@anantmittal
anantmittal marked this pull request as ready for review October 3, 2022 20:11
@anantmittal

Copy link
Copy Markdown
Collaborator Author

test_patients_get test in test_registry_patients.py gets an assertion failure because of mismatch between new values inventory jsonschema and existing values inventory document (matches old values inventory schema) in database.

@jayfo

jayfo commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Confirmed all tests pass with a reset database.

@jayfo jayfo changed the title Activity schedule schemas Updates to Schemas and Flask for ActivitySchedule Documents Oct 15, 2022
@jayfo
jayfo merged commit a5c02bd into uwscope:develop Oct 15, 2022
datetime_now,
)
),
"valueId": "valueId Placeholder",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayfo valueId is an optional field.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #361.

@jayfo jayfo added this to the v0.7.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants