Initial Fixes to Registry View of Values and Activities Inventory - #380
Merged
Conversation
anantmittal
marked this pull request as ready for review
December 16, 2022 20:57
Collaborator
Author
|
@jayfo Ready for review. |
jayfo
reviewed
Dec 22, 2022
jayfo
reviewed
Dec 22, 2022
jayfo
reviewed
Dec 22, 2022
| lastUpdatedDateTime, | ||
| 'MM/dd/yyyy', | ||
| )}`, | ||
| // NOTE: Why did we remove lastUpdatedDateTime from values-inventory.json? |
Contributor
There was a problem hiding this comment.
The field got removed from the values inventory document because keeping it there would have required maintaining it from anywhere that was modifying value or activity documents. We can instead calculate it.
Based on some email I traded w/ Jesse et al in September, we'll calculate this as:
- Obtain all
activitydocuments - Filter those which are not associated with any
value - The most recent time
I think we should then also change the value of patient_values_inventory_activity_date_header to be Last updated on.
Contributor
There was a problem hiding this comment.
Forgot to say, this seems like something we could calculate in the store.
Collaborator
Author
|
@jayfo Pushed the changes you suggested. |
Collaborator
Author
|
@jayfo Ready again. |
jayfo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.