Consistently Sort Sessions by Date - #479
Merged
Merged
Conversation
Not mutating state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying order of sessions objects has been based on
_id, which in turn corresponds to the order in which documents were added to the database. This often appears to also be sorted by date, but that correlation breaks down if a session is edited. A new document will be created for the edit, which will appear most recent regardless of its underlying date.This was showing up as several weird behaviors:
Incorrect and even negative values in the Caseload:
Incorrect dates in the patient summary:
Incorrect dates and potentially incorrect data in treatment summary:
This update fixes all of these issues, consistently sorting sessions by date before using them.