Skip to content

cpu: binary: disable broadcast check for select op#2989

Merged
avmanerikar merged 1 commit intomainfrom
amanerik/main/check-select-broadcast
Apr 2, 2025
Merged

cpu: binary: disable broadcast check for select op#2989
avmanerikar merged 1 commit intomainfrom
amanerik/main/check-select-broadcast

Conversation

@avmanerikar
Copy link
Contributor

Description

The PR disables the check for broadcasted dimensions for the conditional tensor during binary select primitive creation. Doing so stops the primitive creation from failing for a broadcasted select input and instead executes the reference implementation. This is done to allow for the Graph API to move from the select composition implementation and use the select primitive instead.

Related to MFDNN-12979

@avmanerikar avmanerikar requested a review from a team as a code owner April 1, 2025 00:19
@avmanerikar
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable test_device_gpu
disable benchdnn_all
enable benchdnn_binary

@avmanerikar
Copy link
Contributor Author

make test Lightweight_scans

@avmanerikar avmanerikar merged commit 2d41f6f into main Apr 2, 2025
23 checks passed
@avmanerikar avmanerikar deleted the amanerik/main/check-select-broadcast branch April 2, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants